Enhancement #503

Free selection permieter: Coordinates check for manual insert

Added by Blatti Yves almost 8 years ago. Updated about 4 years ago.

Status:ClosedStart date:01/18/2012
Priority:HighDue date:
Assignee:-% Done:

100%

Category:SHOP
Target version:4.3.2
Sponsor: Ergonomic impact:

A message has to pop if coordinate are out of bounds

Functional impact:

We avoid out of bound geometries from beeing inserted


Description

When manually inserting coordinates on step 2, they're only tested for non-numerical values.

They should be tested against a BBox ton ensure quality, p.e by extending isValidCoordinates() in mod_easysdi_perimeter/mod_easysdi_perimeter.php.

We temporary fixed by adding:

else{
    if( !( yVal > 100000 && yVal < 250000 && xVal > 450000 && xVal < 600000 )){
        alert('<?php echo JText::_("EASYSDI_PERIMETER_MESSAGE__ERROR_COORD_VALUE_INVALID");?>');
        return false;
    }
    else 
    {
        return true;
    }
}

Question: Where should the values come from?
- Max map extent?
- Custom parameters?

History

#1 Updated by Magoni Bruno over 5 years ago

  • Project changed from SHOP to easySDI

#2 Updated by Magoni Bruno over 5 years ago

  • Category set to SHOP

#3 Updated by Blatti Yves almost 5 years ago

  • Assignee set to Blatti Yves

Need to write specs to port this feature on 4.X

#4 Updated by Blatti Yves over 4 years ago

  • Tracker changed from Feature to Enhancement
  • Status changed from New to Request For Comments
  • Assignee changed from Blatti Yves to Technical Committee
  • Functional impact set to We avoid out of bound geometries from beeing inserted
  • Ergonomic impact set to A message has to pop if coordinate are out of bounds

Linked to : #961

If we "manually" insert polygons (import), we have to check for coordinates to be in restricted bounds.

I suggest using the MAP restricted extent. Is it OK for all of you ?

#5 Updated by Blatti Yves over 4 years ago

  • Priority changed from Normal to High

#6 Updated by Van Hoecke Hélène over 4 years ago

  • Status changed from Request For Comments to Accepted
  • Assignee changed from Technical Committee to Blatti Yves

#7 Updated by Blatti Yves about 4 years ago

  • Status changed from Accepted to Affected

#8 Updated by Blatti Yves about 4 years ago

  • Status changed from Affected to Resolved
  • % Done changed from 0 to 100

Rev. 8896

#9 Updated by Blatti Yves about 4 years ago

  • Status changed from Resolved to To merge

#10 Updated by Blatti Yves about 4 years ago

  • Assignee changed from Blatti Yves to Villemagne Jérôme

#11 Updated by Villemagne Jérôme about 4 years ago

  • Status changed from To merge to Closed
  • Assignee deleted (Villemagne Jérôme)
  • Target version set to 4.3.2

Also available in: Atom PDF